Repository navigation
Refactor of particle initialisation - #33
Carpenteri0 wants to merge 19 commits into
Conversation
…ns have their own module and bundling type, this commit compiles
…n rej function and variables seperately, evaluating the rej_f has its own subroutine now too
|
Hi @Carpenteri0 , you should be able to add reviewers to the pull request once it's ready. |
…rror related to calling interp_PRZ
Hi @N-Schwarz , my apologies. I've added reviewers now. I think I've fixed the compile issues in the build tests, but as I don't have these issues with my setup, we'll have to wait for the tests to complete. |
There was a problem hiding this comment.
Old RE inputs that still set num_re will now fail at namelist read with a generic error. It would be worth a line pointing to n_particles_total
There was a problem hiding this comment.
I changed num_re in the only .md where it turned up, and the reg_tests. Hopefully any RE people already using kinetic_main will notice this change, where else would you suggest leaving a comment?
| zj_lo = 1.d10; zj_hi = -1.d10 | ||
| R_lo = 1.d10; R_hi = -1.d10 | ||
|
|
||
| do i_elm = 1, element_list%n_elements |
There was a problem hiding this comment.
jzmin/jzmax now come from the whole domain. Can it go <0 ? If we are not sure it's better to cap it to 0?
There was a problem hiding this comment.
Current can go either way in the tokamak, right? I guess usually it is largely in one direction, but in general I don't think there is anything physical prohibiting regions of opposing current. Ie jz can be both positive and negative at different points for the same time.
|
Hi @N-Schwarz , @Daniel-Maris . I've addressed @edo01 comments now, have you had a chance to take a look at this PR? I believe its ready (and significantly cleans up the previous state of initialising EPs/REs in kinetic_main) |
|
Quick comments from Daniel after chat in Culham (for bookeeping).
^^ Only really naming changes, but atm not obvious at all, this PR is probably the best place to make these name changes. |
This branch has not been deployed
3 participants
Mostly backend aesthetic changes. Main change is rejection functions have their own module, with type definitions, a few helper subroutines, and all existing rej funcs that were previously in ~3 other modules. Other smaller changes :